Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce no-throw-literal #32331

Merged
merged 1 commit into from
Nov 29, 2024
Merged

chore: enforce no-throw-literal #32331

merged 1 commit into from
Nov 29, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Nov 29, 2024 •
edited
Loading

Reason for this change

As part of #32324 we are enforcing stricter rules on thrown errors.

Description of changes

Enforce the no-throw-literal eslint rule.
Fix the one instance that wasn't compliant yet.

Description of how you validated changes

Manual testing. Only changed code is in supporting CLI tool.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 29, 2024 11:49
@mrgrain mrgrain removed the p2 label Nov 29, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 29, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (77fbddf) to head (7cf2b22).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #32331      +/-   ##
==========================================
- Coverage   78.45%   78.42%   -0.03%     
==========================================
  Files         106      106              
  Lines        7208     7208              
  Branches     1323     1323              
==========================================
- Hits         5655     5653       -2     
- Misses       1365     1368       +3     
+ Partials      188      187       -1
Flag Coverage Δ
suite.unit 78.42% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.42% <ø> (-0.03%) ⬇️

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7cf2b22
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 29, 2024
@github-actions github-actions bot added the p2 label Nov 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain merged commit 0e79874 into main Nov 29, 2024
37 of 39 checks passed
@mrgrain mrgrain deleted the mrgrain/chore/no-throw-literal branch November 29, 2024 14:02
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrgrain @aws-cdk-automation @otaviomacedo